bug in dataBoundComponent.exportData

[janusz]

Hi,

I am testing with version 13.0 2023-09-09.

In dataBoundComponent.exportData there is fragment that combines implicit criteria with regular criteria.

var criteria = isc.DS.compressNestedCriteria(
            (ds || isc.DS).combineCriteria(this.getImplicitCriteria(true), this.getCriteria())
    );

If implicitCriteria are advanced and criteria are simple and criteria contains at least on field with type text, textMatchStyle is lost.

textMatchStyle is stored earlier in requestProperties, but it will not be used when converting criteria to combine with implicitCriteria.
textMatchStyle will be later passed on to dataSource.exportData, but as passed combined criteria will be already advanced, it will not be used.

I think that you should change that fragment to something like:

var criteria = isc.DS.compressNestedCriteria(
            (ds || isc.DS).combineCriteria(this.getImplicitCriteria(true), this.getCriteria(), "and", requestProperties.textMatchStyle)
    );

Best regards,
Janusz

[Isomorphic]

Thanks for the report - we agree that calls to combineCriteria() need a textMatchStyle in most cases, and we've corrected this one for tomorrow's builds, dated September 13 or later.

[janusz]

Guys, you forgot third argument for DS.combineCriteria in dataBoundComponent.exportData

criteria = (ds || isc.DS).combineCriteria(implicitCriteria, criteria,
                        requestProperties.textMatchStyle);

should be

criteria = (ds || isc.DS).combineCriteria(implicitCriteria, criteria, "and",
                        requestProperties.textMatchStyle);

Best regards,
Janusz

[Isomorphic]

Apologies, we've corrected this, tweaked a couple of other calls to combineCriteria() so they include a textMatchStyle where one is available, and added some autotests in this area.

Please retest with a build dated September 18 or later.