Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    ToggleSwitch title

    SmartClient Version: SNAPSHOT_v13.1d_2024-03-18/Enterprise Deployment (built 2024-03-18)

    Chrome on MacOS

    Hello, I'm trying the ToggleSwitch, and I think I've found a problem with the title, please try this test case:

    Code:
    isc.VLayout.create({
        membersMargin: 5,
        members: [
            isc.Header.create({ title:"Standalone Toggle" }),
            isc.ToggleSwitch.create({ ID:"toggleSwitch", title:"foo", showTitle:true})
        ]
    });
    and this is what happens:

    Click image for larger version

Name:	2024-03-18 12.54.36.jpg
Views:	61
Size:	4.7 KB
ID:	271885

    #2
    hi Claudio,

    If you check the docs for that property, it notes that it's a Slider property and not applicable to ToggleSwitch - we'll make a change to properly disable it in this widget.

    Comment


      #3
      Thanks for the heads up, so I need to use it as a formItem to have a title.

      Comment


        #4
        But it seems that changed is not working on the ToggleItem:

        Code:
        isc.VLayout.create({
            membersMargin: 5,
            members: [
                isc.Header.create({ title:"Toggle in a form" }),
                isc.DynamicForm.create({
                    fields: [
                        { name:"toggle", title:"Enable Noise Cancellation", changed: function(form, item, value) {isc.logEcho("foo")},
                         wrapTitle:false, editorType:"ToggleItem" }
                    ]
                })
            ]
        });

        Comment


          #5
          hi Claudio,

          You're right, there was some change-detection plumbing missing here. However, there was also an existing task to redo the ToggleSwitch in a simpler form, and we've now done that - it's now a StatefulCanvas and we've added color-transitions and thumb-animation, and support for changing value with the keyboard (space or left/right arrow). And change-detection now works as expected in ToggleItem.

          Please retest with tomorrow's builds, dated March 21 or later.
          Last edited by Isomorphic; 20 Mar 2024, 04:17.

          Comment


            #6
            SmartClient Version: SNAPSHOT_v13.1d_2024-03-22/AllModules Development Only (built 2024-03-22)

            thank you very much, much better now, on handset devices also

            Comment


              #7
              Actually I found a visual glitch when disabling/enabling the ToggleItem, here it is disabled after running the test case (seems fine):

              Click image for larger version  Name:	2024-03-22 12.15.49.jpg Views:	0 Size:	6.1 KB ID:	271936

              then after enabling it:

              Click image for larger version  Name:	2024-03-22 12.15.53.jpg Views:	0 Size:	6.3 KB ID:	271934
              then after toggling:
              Click image for larger version  Name:	2024-03-22 12.15.56.jpg Views:	0 Size:	6.4 KB ID:	271938

              again after disabling:​

              Click image for larger version  Name:	2024-03-22 12.16.00.jpg Views:	0 Size:	5.9 KB ID:	271933

              test case:

              Code:
              isc.VLayout.create({
                  membersMargin: 5,
                  members: [
                      isc.DynamicForm.create({
                          ID: "aForm",
                          fields: [
                              {name: "aCheckbox", type: "checkbox", title: "Enable Toggle"},
                          ]
                      }),
                      isc.DynamicForm.create({
                          enableWhen: {
                              _constructor: "AdvancedCriteria",
                              operator: "and",
                              criteria: [{fieldName: "aForm.values.aCheckbox", operator: "equals", value: true}]
                          },
                          fields: [
                              {
                                  name: "toggle", title: "Enable Noise Cancellation", defaultValue: false,
                                  wrapTitle: false, editorType: "ToggleItem"
                              }
                          ]
                      })
                  ]
              });
              Attached Files
              Last edited by claudiobosticco; 22 Mar 2024, 03:24.

              Comment


                #8
                Thanks Claudio - we've corrected baseStyle handling for tomorrow's builds.

                Comment


                  #9
                  SmartClient Version: SNAPSHOT_v13.1d_2024-03-30/AllModules Development Only (built 2024-03-30)

                  I see it's fixed, thank you very much

                  Comment

                  Working...
                  X