skin editor not working for Shiva skin

[Isomorphic]

Thanks Claudio - we'll take a look at these over the next few days

[claudiobosticco]

Hello, while I'm trying it (and seems to actually work), I noticed that the TabButton Over Border color isn't updated after changing the Highlight color.

Also the TourButton colors, and the LoginForm Button colors.

moreover, in "Select View", the SectionStack is missing.

[claudiobosticco]

now the export seems to work, may I assume it's actually fixed?

[claudiobosticco]

SNAPSHOT_v13.1d_2024-05-23/Enterprise Development Only

Hello, I still see the error when trying to export a modified skin:

=== 2024-05-23 15:05:17,673 [ec-6] INFO RequestContext - URL: '/isomorphic/IDACall', User-Agent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36': Safari with Accept-Encoding header
=== 2024-05-23 15:05:17,676 [ec-6] INFO IDACall - Performing 1 operation(s) [UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36]
=== 2024-05-23 15:05:17,676 [ec-6] INFO DSRequest - Executing isc_userSkin.fetch rows: 0->-1 with
criteria: {name:"JShiva"}
=== 2024-05-23 15:05:17,694 [ec-6] INFO CDIBeanManager - Unable to find BeanManager via java:comp/env/BeanManager - will try java:comp/BeanManager
=== 2024-05-23 15:05:17,694 [ec-6] INFO CDIBeanManager - Unable to find BeanManager via java:comp/env/BeanManager
=== 2024-05-23 15:05:17,695 [ec-6] INFO DSRequest - Executing isc_userSkin.fetch rows: 0->-1 with
criteria: {name:"JShiva"}
=== 2024-05-23 15:05:17,696 [ec-6] INFO SQL - Executing SQL query on 'HSQLDB': SELECT isc_userSkin.pk, isc_userSkin.name, isc_userSkin.baseSkin, isc_userSkin.userSettings, isc_userSkin.skinStylesCSS, isc_userSkin.thumbnail, isc_userSkin.created_by, isc_userSkin.created_at, isc_userSkin.modified_by, isc_userSkin.modified_at, isc_userSkin.version FROM isc_userSkin WHERE (LOWER(isc_userSkin.name)='jshiva')
=== 2024-05-23 15:05:17,697 [ec-6] INFO DSResponse - DSResponse: List with 1 items
=== 2024-05-23 15:05:17,697 [ec-6] INFO DSResponse - DSResponse: List with 1 items
=== 2024-05-23 15:05:17,710 [ec-6] INFO Compression - /isomorphic/IDACall: 350,3k -> 38,4k
=== 2024-05-23 15:05:18,347 [ec-8] INFO RequestContext - URL: '/isomorphic/IDACall', User-Agent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36': Safari with Accept-Encoding header
=== 2024-05-23 15:05:18,365 [ec-8] INFO IDACall - Performing 1 operation(s) [UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36]
=== 2024-05-23 15:05:18,370 [ec-8] INFO DSRequest - Executing isc_userSkin.custom[export] with
criteria: {}
values: {
    name:"JShiva",
    baseSkin:"Shiva",
    content:"//>theme_variables\n// ==== Global Settings - Flags and other settings that have skin-wide effects\n// General settings\n$theme_name: 'JShiva';\n$transition_normal_speed: 0.2s;\n// State Opacities\n$standard_opacity: 1.0;\n$standard_over_opacity: 0.9;\n$standard_down_opacity: 0.7;\n$standard_focused_opacity: 0.8;\n$standard_selected_opacity: 1.0;\n$standard_disabled_opacity: 0.5;\n\n// ==== Fonts - Variables for fonts\n// Definitions\n$primary_font: Roboto-Light-Vivid;\n$secondary_font: Roboto-Light-Vivid;\n$secondary_font_bold: Roboto-Light-Vivid;\n$tertiary_font: Roboto-Light-Vivid;\n$standard_font: $tertiary_font;\n$normal_font: $primary_font;\n// Widget\n$standard_body_font: $standard_font;\n$standard_header_font: $tertiary_font;\n$standard_tab_font: $secondary_font;\n$standard_hover_font: $standard_body_font;\n// Font sizes\n$standard_font_size: 11px;\n$normal_font_size: 12px;\n$standard_small_font_size: 9px;\n$stand... [set log category to DEBUG to see full object]
=== 2024-05-23 15:05:18,372 [ec-8] INFO DSRequest - Executing isc_userSkin.fetch rows: 0->-1 with
criteria: {name:"JShiva"}
=== 2024-05-23 15:05:18,372 [ec-8] INFO CDIBeanManager - Unable to find BeanManager via java:comp/env/BeanManager - will try java:comp/BeanManager
=== 2024-05-23 15:05:18,372 [ec-8] INFO CDIBeanManager - Unable to find BeanManager via java:comp/env/BeanManager
=== 2024-05-23 15:05:18,442 [ec-8] INFO DSRequest - Executing isc_userSkin.fetch rows: 0->-1 with
criteria: {name:"JShiva"}
=== 2024-05-23 15:05:18,443 [ec-8] INFO SQL - Executing SQL query on 'HSQLDB': SELECT isc_userSkin.pk, isc_userSkin.name, isc_userSkin.baseSkin, isc_userSkin.userSettings, isc_userSkin.skinStylesCSS, isc_userSkin.thumbnail, isc_userSkin.created_by, isc_userSkin.created_at, isc_userSkin.modified_by, isc_userSkin.modified_at, isc_userSkin.version FROM isc_userSkin WHERE (LOWER(isc_userSkin.name)='jshiva')
=== 2024-05-23 15:05:18,444 [ec-8] INFO DSResponse - DSResponse: List with 1 items
=== 2024-05-23 15:05:18,444 [ec-8] INFO DSResponse - DSResponse: List with 1 items
=== 2024-05-23 15:05:18,444 [ec-8] INFO DSRequest - Executing isc_baseSkin.fetch rows: 0->-1 with
criteria: {name:"Shiva"}
=== 2024-05-23 15:05:18,445 [ec-8] INFO CDIBeanManager - Unable to find BeanManager via java:comp/env/BeanManager - will try java:comp/BeanManager
=== 2024-05-23 15:05:18,445 [ec-8] INFO CDIBeanManager - Unable to find BeanManager via java:comp/env/BeanManager
=== 2024-05-23 15:05:18,454 [ec-8] INFO DSResponse - DSResponse: List with 1 items
=== 2024-05-23 15:05:18,475 [ec-8] INFO ProxyHttpServletResponse - content-disposition set to: attachment; fileName=JShiva.zip - unwrapping response output stream (CompressionFilter)
=== 2024-05-23 15:05:18,475 [ec-8] WARN RequestContext - dsRequest.execute() failed: java.lang.NullPointerException
    at com.isomorphic.util.SkinUtil.export(SkinUtil.java:609)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.isomorphic.base.Reflection._invokeMethod(Reflection.java:812)
    at com.isomorphic.base.Reflection.adaptArgsAndInvoke(Reflection.java:1127)
    at com.isomorphic.datasource.DataSourceDMI.execute(DataSourceDMI.java:436)
    at com.isomorphic.datasource.DataSourceDMI.execute(DataSourceDMI.java:64)
    at com.isomorphic.datasource.DSRequest.execute(DSRequest.java:3676)
    at com.isomorphic.servlet.IDACall.handleDSRequest(IDACall.java:249)
    at com.isomorphic.servlet.IDACall.processRPCTransaction(IDACall.java:206)
    at com.isomorphic.servlet.IDACall.processRequest(IDACall.java:153)
    at com.isomorphic.servlet.IDACall._processRequest(IDACall.java:123)
    at com.isomorphic.servlet.IDACall.doPost(IDACall.java:79)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:555)
    at com.isomorphic.servlet.BaseServlet.service(BaseServlet.java:178)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:623)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:199)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.servlet.URIRegexFilter.ignore(URIRegexFilter.java:566)
    at com.isomorphic.servlet.URIRegexFilter.ignore(URIRegexFilter.java:561)
    at com.isomorphic.servlet.URIRegexFilter.matchedRule(URIRegexFilter.java:524)
    at com.isomorphic.servlet.URIRegexFilter._doFilter(URIRegexFilter.java:377)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.js.JSSyntaxScannerFilter._doFilter(JSSyntaxScannerFilter.java:262)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.servlet.CompressionFilter._doFilter(CompressionFilter.java:263)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.servlet.VersionedURLFilter._doFilter(VersionedURLFilter.java:83)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:481)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346)
    at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:388)
    at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
    at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:928)
    at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1791)
    at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
    at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1190)
    at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
    at java.lang.Thread.run(Thread.java:748)

am I missing some step?

[claudiobosticco]

thanks for the notification, no new 13.1 builds after May 19 for now

[Isomorphic]

hi Claudio,

This issue has been fixed for builds dated May 20 and later.

[Isomorphic]

hi Claudio, thanks for the report.

We saw an issue similar to this inhouse recently - a fix was made but we'll revisit in the next day or two and update here when we get to the bottom of it.

[claudiobosticco]

I also get an error when trying to export a modified skin:

=== 2024-05-08 14:36:18,567 [ec-4] WARN RequestContext - dsRequest.execute() failed: java.lang.NullPointerException
    at com.isomorphic.util.SkinUtil.export(SkinUtil.java:609)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.isomorphic.base.Reflection._invokeMethod(Reflection.java:812)
    at com.isomorphic.base.Reflection.adaptArgsAndInvoke(Reflection.java:1127)
    at com.isomorphic.datasource.DataSourceDMI.execute(DataSourceDMI.java:436)
    at com.isomorphic.datasource.DataSourceDMI.execute(DataSourceDMI.java:64)
    at com.isomorphic.datasource.DSRequest.execute(DSRequest.java:3676)
    at com.isomorphic.servlet.IDACall.handleDSRequest(IDACall.java:249)
    at com.isomorphic.servlet.IDACall.processRPCTransaction(IDACall.java:206)
    at com.isomorphic.servlet.IDACall.processRequest(IDACall.java:153)
    at com.isomorphic.servlet.IDACall._processRequest(IDACall.java:123)
    at com.isomorphic.servlet.IDACall.doPost(IDACall.java:79)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:555)
    at com.isomorphic.servlet.BaseServlet.service(BaseServlet.java:178)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:623)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:200)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:169)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.servlet.URIRegexFilter.ignore(URIRegexFilter.java:566)
    at com.isomorphic.servlet.URIRegexFilter.ignore(URIRegexFilter.java:561)
    at com.isomorphic.servlet.URIRegexFilter.matchedRule(URIRegexFilter.java:524)
    at com.isomorphic.servlet.URIRegexFilter._doFilter(URIRegexFilter.java:377)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:169)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.js.JSSyntaxScannerFilter._doFilter(JSSyntaxScannerFilter.java:262)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:169)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.servlet.CompressionFilter._doFilter(CompressionFilter.java:263)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:169)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at com.isomorphic.servlet.VersionedURLFilter._doFilter(VersionedURLFilter.java:83)
    at com.isomorphic.servlet.BaseFilter.doFilter(BaseFilter.java:91)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:169)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:481)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346)
    at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:390)
    at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
    at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:928)
    at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1786)
    at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
    at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
    at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
    at java.lang.Thread.run(Thread.java:748)

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-05-08/Enterprise Development Only (built 2024-05-08)

Hello, I've just noticed that if I try to create a skin based on the Shiva skin with the latest build, I get this error:

15:57:19.899:WARN:Log:Usage: action=appShowStartPane, data=showStartPane, data2=
15:57:20.238:WARN:Log:TypeError: Cannot read properties of undefined (reading 'usedBy')
Stack from error.stack:
    _3.<anonymous>(<no args: exited>) on [DataSource ID:isc_baseSkin] @ skinEditor.jsp:2076:46
    [c]Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>[DataSource ID:isc_baseSkin], _5=>undef) on [Class DataSource] @ ISC_Core.js:333:252
    Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>undef) on [DataSource ID:isc_baseSkin] @ ISC_Core.js:427:302
    DataSource.fireResponseCallbacks(_1=>Obj, _2=>Obj, _3=>Obj, _4=>Obj) on [DataSource ID:isc_baseSkin] @ ISC_DataBinding.js:653:89
    DataSource._completeResponseProcessing(_1=>Array[1], _2=>Obj, _3=>Obj, _4=>Obj, _5=>Obj) on [DataSource ID:isc_baseSkin] @ ISC_DataBinding.js:648:6
    DataSource._handleSCServerReply(_1=>Obj, _2=>Array[1], _3=>Obj) on [DataSource ID:isc_baseSkin] @ ISC_DataBinding.js:2891:6
    [c]Class.fireCallback(<no args: recursion>) on [Class RPCManager] @ ISC_Core.js:333:252
    Class.fireCallback(<no args: recursion>) on [RPCManager ID:builtinApplication] @ ISC_Core.js:427:302
    [c]RPCManager.fireReplyCallback(_1=>Obj, _2=>Obj, _3=>Obj, _4=>Array[1]) on [Class RPCManager] @ ISC_DataBinding.js:1730:309
    [c]RPCManager.fireReplyCallbacks(_1=>Obj, _2=>Obj) on [Class RPCManager] @ ISC_DataBinding.js:1733:120
    [c]RPCManager.completeOperationReply(_1=>Obj, _2=>Obj) on [Class RPCManager] @ ISC_DataBinding.js:1724:6
    [c]RPCManager.performOperationReply(_1=>Obj, _2=>Obj) on [Class RPCManager] @ ISC_DataBinding.js:1722:109
    RPCManager._performTransactionReply(_1=>53) on [Class RPCManager] @ ISC_DataBinding.js:1651:26
    [c]RPCManager.performTransactionReply(_1=>53, _2=>"//isc_RPCResponseStart-->[{affectedRows:..."[588462], _3=>undef) on [Class RPCManager] @ ISC_DataBinding.js:1609:20
    null.eval(transactionNum=>53, results=>[object XMLHttpRequest], wd=>undef) @ [no file]:3:16
    [c]Class.fireCallback(<no args: recursion>) on [Class Comm] @ ISC_Core.js:333:252
    [c]Comm.performXmlTransactionReply(_1=>53, _2=>[object XMLHttpRequest]) on [Class Comm] @ ISC_Core.js:2289:27
    null.eval(xmlHttpRequest=>[object XMLHttpRequest]) @ [no file]:3:10
    [c]Class.fireCallback(<no args: recursion>) on [Class Class] @ ISC_Core.js:333:252
    Comm._fireXMLCallback(_1=>[object XMLHttpRequest], _2=>"isc.Comm.performXmlTransactionReply(53, ..."[55], _3=>undef) on [Class Comm] @ ISC_Core.js:2264:451
    XMLHttpRequest._15() @ ISC_Core.js:2273:135