13.1d Shiva icon and all skin inline icon positioning

[Blama]

Hi Isomorphic,

please see these screenshots of the 13.1d showcase (SNAPSHOT_v13.1d_2024-06-09) taken in Win10 FF126 iPhone 12/13 mode, but also happening like this on my iPhone SE 2022 (iOS 17).

The icon used in the 1st screenshot looks like a 3D Enterprise skin icon. It is also used in Tahoe, but does not stand out there that much. It looks out of place in Shiva IMHO.

The TextItem in the 2nd screenshot has misplaced inline icons.

Best regards
Blama

[Blama]

Clicks on the two misplaced icons cause JS errors in Firefox in 13.0p and 13.1d. Not sure if this also happens on the real device.

*17:58:47.670:TUP8:WARN:Log:TypeError: _4.getField(...) is null
Stack from error.stack:
iconClick@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/development/ISC_ExampleViewer.js?isc_version=v13.0p_2024-06-09.js:208:2531
isc_FormItem__iconClick@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Forms.js?isc_version=v13.0p_2024-06-09.js:1580:28
isc_DynamicForm_handleItemClick@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Forms.js?isc_version=v13.0p_2024-06-09.js:777:53
isc_DynamicForm_handleClick@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Forms.js?isc_version=v13.0p_2024-06-09.js:775:508
isc_c_EventHandler_bubbleEvent@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2581:89
isc_c_EventHandler_handleClick@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2389:50
isc_c_EventHandler__handleMouseUp@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2371:11
isc_c_EventHandler__handleTouchEnd@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2417:119
isc_c_EventHandler_dispatch@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2680:122
anonymous@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js line 92 > Function:3:125
EventListener.handleEvent*isc_c_EventHandler_captureEvent@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2684:4
isc_c_EventHandler_captureEvents@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2697:484
@https://www-demos.smartclient.com/smartclient-13.0/isomorphic/system/modules/ISC_Core.js?isc_version=v13.0p_2024-06-09.js:2829:56

[claudiobosticco]

Hi Blama with latest 13.1 and a iPhone (real physical device) I still see the icons misplaced.

No js errors when clicking them tho.

The "gears" icon has been changed.

[Isomorphic]

We've fixed this - it was just a result of titleOrientation: "top" on the items resulting in the table that v-centers the inline icons being too tall.

Please see tomorrow's builds.

[Blama]

Hi Isomorphic,

I can see the design issue is fixed with SNAPSHOT_v13.1d_2024-06-28. But now the "X" in the textbox does not have an effect (but also does not cause a JS exception).
Tested in Win10 FF127 iPhone 12/13 mode.

Best regards
Blama

[claudiobosticco]

Hi Blama Isomorphic, with the latest 13.1, on a iPhone 8 (physical device), I see again a misplacing of the icons:



the X clears correctly the form item tho.

[Blama]

Hi, you are right. I see the same on my iPhone SE 2022.