[claudiobosticco]

Now I see it, thank you very much!

[Isomorphic]

hi Claudio - we've modified the packager to also include the skin template folders in the runtime, since the Skin Editor needs them to recompile custom skins. You should see the change in today's builds, dated October 25, and later ones.

[claudiobosticco]

Hello, yes, you're right. In my post #32, I tried to clarify things:
- There isn't an actual bug; the issue was due to my mistake.
- My only question is whether it's possible to make the template folder, which is currently included only in the SDK's skins (and not in the runtime), available for download via Maven - perhaps with a dedicated artifact.

This is the only step I can't fully automate in my Maven "skin editor" project at the moment.

[Isomorphic]

hi Claudio - sorry for the silence on this thread - we've lost track a bit of the remaining issues in this thread - can you confirm which parts are still open?

[claudiobosticco]

Hello, I need to apologize. I realized that the issue is due to my oversight. I’ve now added a WARN in the Maven build to remind myself about it.

Basically, the problem is related to what I mentioned in posts #4 and #5, which is that the template folder is missing in the skin folders present in the runtime, and therefore my Maven build cannot copy it. So, I need to remember to update it manually. The error was caused by some variable missing in my (old) _base.scss file.

Would it be possible to add an artifact that allows obtaining those folders through Maven?

ok, I see in the skinEditor.jsp that the actionURL is modified to that path if the user is authenticated.
I've actually modified skinEditor.jsp to work with my local authentication. Am I actually supposed to do that?

If I comment out the line where the actionURL is modified, the skinEditor doesn't find any skin because it's looking for the template folder inside the skins folders, which is absent in my deployment. On the other hand, also the skinEditorOperations folder is absent.

So I need to ask: is the skin editor actually ready to deploy in our own project? Am I missing some steps?

I must specify that I'm using maven. Maybe am I missing some maven dependency to have the "template" folder for the skins?

[claudiobosticco]

Hello, any news about this issue (posts #27/28)?

[claudiobosticco]

From the logs you showed, we believe the issue reported in post #22 was caused by us changing the type of not only the fields in the isc_userSkin DS but also the ones in isc_baseSkin. So, we removed the types again from isc_baseSkin.

Leave it with us - we'll figure it out and get back to you.

oh, I see now, thanks for looking into it

[claudiobosticco]

hi Claudio - have you been updating the /tools dir? Do you now see that the /tools/skinTools/data/isc_baseSkin.ds.xml file no longer sets type="text"? That was the change that was made.

sorry, re-reading I see that you mentioned isc_baseSkin, not isc_userSkin. I saw that you added type="text" to isc_userSkin.

I don't see changes to isc_baseSkin. And in this ds there aren't type="text" attributes. Is that important?

[Isomorphic]

From the logs you showed, we believe the issue reported in post #22 was caused by us changing the type of not only the fields in the isc_userSkin DS but also the ones in isc_baseSkin. So, we removed the types again from isc_baseSkin.

Leave it with us - we'll figure it out and get back to you.

[claudiobosticco]

Hello Isomorphic, yes I saw that change, but I understood that there was also a fix for the problem of post #22.

With builds after v13.1d_2024-08-25, when I try to load my custom skin, I see those warnings, and it doesn't show data in the themeEditor_tabSet, and shows nothing in the themeEditor preview. Same if I try to create a new custom skin.

[Isomorphic]

hi Claudio - have you been updating the /tools dir? Do you now see that the /tools/skinTools/data/isc_baseSkin.ds.xml file no longer sets type="text"? That was the change that was made.

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-08-31/AllModules Development Only (built 2024-08-31)

still no luck, let me know when I may retry

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-08-30/Enterprise Development Only (built 2024-08-30)

Hello, the fix doesn't seem there, I'll retry with tomorrow's build.

[Isomorphic]

hi Claudio,

We applied a fix for today's builds that will likely fix this error - we've also tweaked the flows that resulted in the other warnings in your log, but those changes won't land until tomorrow's builds.

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-08-28/Enterprise Development Only (built 2024-08-28)

Hello, I see the addition of type="text", but now I've got this error while trying to load my custom skin in the skin editor:

Remote Debugging unavailable (Messaging endpoint not responding). To enable Remote Debugging, see the Remote Debugging overview in the reference.
11:17:05.203:WARN:Log:Usage: action=appShowStartPane, data=showStartPane, data2=
11:17:05.529:WARN:Log:value is null in getUsedVariables() -
    [a]Class.getUsedVariables(value=>undef)
    $376(dsResponse=>Obj, data=>Array[1], Obj)
    [c]Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>[DataSource ID:isc_baseSkin], _5=>undef)
    Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>undef)
    DataSource.fireResponseCallbacks(_1=>Obj, _2=>Obj, _3=>Obj, _4=>Obj)
    DataSource.$38b(_1=>Array[1], _2=>Obj, _3=>Obj, _4=>Obj, _5=>Obj)
    DataSource.$50h(_1=>Obj, _2=>Array[1], _3=>Obj)
    ** recursed on [c]Class.fireCallback

11:17:05.530:WARN:Log:value is null in getUsedVariables() -
    [a]Class.getUsedVariables(value=>undef)
    $376(dsResponse=>Obj, data=>Array[1], Obj)
    [c]Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>[DataSource ID:isc_baseSkin], _5=>undef)
    Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>undef)
    DataSource.fireResponseCallbacks(_1=>Obj, _2=>Obj, _3=>Obj, _4=>Obj)
    DataSource.$38b(_1=>Array[1], _2=>Obj, _3=>Obj, _4=>Obj, _5=>Obj)
    DataSource.$50h(_1=>Obj, _2=>Array[1], _3=>Obj)
    ** recursed on [c]Class.fireCallback

11:17:05.743:WARN:themeEditor:Error propagating theme to observer: themeEditor - TypeError: record.value is undefined
    [a]Class.themeChangedNotify(observer=>[ThemeEditor ID:themeEditor])
    $376(dsResponse=>Obj, data=>Array[1], Obj)
    [c]Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>[DataSource ID:isc_baseSkin], _5=>undef)
    Class.fireCallback(_1=>$376(), _2=>"dsResponse,data,dsRequest", _3=>Array[3], _4=>undef)
    DataSource.fireResponseCallbacks(_1=>Obj, _2=>Obj, _3=>Obj, _4=>Obj)
    DataSource.$38b(_1=>Array[1], _2=>Obj, _3=>Obj, _4=>Obj, _5=>Obj)
    DataSource.$50h(_1=>Obj, _2=>Array[1], _3=>Obj)
    ** recursed on [c]Class.fireCallback

11:17:05.747:WARN:Log:Usage: action=appLoadSkin, data=Juventus_Light, data2=

this was working until SmartClient Version: SNAPSHOT_v13.1d_2024-08-25/Enterprise Development Only (built 2024-08-25) (stopped working with 2024-08-26 actually)