Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    windowHeader icons color in Shiva

    SmartClient Version: SNAPSHOT_v13.1d_2024-07-04/AllModules Development Only (built 2024-07-04)

    Hello, maybe you've already noticed, but in the latest Shiva the icons in the Window header are not clearly visible (windowHeaderIcons sample):

    Click image for larger version

Name:	2024-07-04 14.37.03.jpg
Views:	26
Size:	11.4 KB
ID:	272813

    Attached Files

    #2
    Also, if you run the same sample with another flat skin, you will notice flickering when hovering over the icons

    Comment


      #3
      Thanks Claudio - yes, this one is already known - those icons were switched to SVG yesterday and the sample code happens to create ImgButtons, which have a builtin class with icon-colors for SVGs. If you set baseStyle: null on the custom ImgButton class in the sample, you'll see the icons appear more visibly, albeit still not in the right color!

      We'll address it, most likely before tomorrow's build.

      Comment


        #4
        Thanks, I see, but please note that there's the same problem with default icons (ie close, minimize, ...):

        Click image for larger version

Name:	2024-07-04 15.20.10.jpg
Views:	29
Size:	31.1 KB
ID:	272817

        Comment


          #5
          Yes, unfortunately, those are ImgButtons as well - it isn't clear why these are all buttons and not just Img, but we'll get to the bottom of it, address it and let you know.

          Comment


            #6
            hi Claudio,

            You should find this fixed in today's builds - we've removed the color-settings from the general .imgButton class, so icons in the headerIcons sample inherit from the header title-color, for example - and we've added a new general class .headerIcon, with colors for icons in headers, and applied it to default Window icons like the Close button.

            Comment


              #7
              SmartClient Version: SNAPSHOT_v13.1d_2024-07-05/AllModules Development Only (built 2024-07-05)

              Hello, I see it's fixed, thank you very much, but maybe the size and/or position of the minimize icon could be better:

              Click image for larger version

Name:	2024-07-05 15.06.56.jpg
Views:	23
Size:	9.7 KB
ID:	272826

              Comment


                #8
                Originally posted by claudiobosticco View Post
                maybe the size and/or position of the minimize icon could be better
                I see this is also fixed, thank you very much

                Comment

                Working...
                X