duplicated css in Shiva?

[claudiobosticco]

Hello, I've just noticed that in Shiva there are these two definitions in skin_styles.css:

/* hover canvas */
.canvasHover,
.gridHover,
.formHover,
.asyncErrorHover {
  background-color: rgba(255, 255, 255, 0.9);
  color: #444444;
  font-family: Roboto-Light-Vivid, Arial, Helvetica, sans-serif;
  font-size: 11px;
  padding: 8px 12px 8px 12px;
  border: 1px solid #3db271;
  -moz-border-radius: 2px;
  -webkit-border-radius: 2px;
  border-radius: 2px;
}

.canvasHover,
.gridHover,
.formHover {
  background-color: rgba(255, 255, 255, 0.9);
  color: #444444;
  border-radius: 2px;
  font-family: Roboto-Light-Vivid;
  font-size: 11px;
  padding: 8px 12px 8px 12px;
  box-shadow: 0 4px 5px rgba(0, 0, 0, 0.2);
  transition: opacity 0.2s;
}

[Isomorphic]

Thanks Claudio - we've combined these two blocks in Shiva for tomorrow's builds, dated August 25 and later.

[claudiobosticco]

Thanks, there are also some other styles which seems a bit suspicious to me as there seems to be a duplication and a lack of font family fallbacks:

1. groupNode

.groupNode {
  color: #444444;
  font-family: Roboto-Light-Vivid;
}

which has another definition with another color and font-family fallbacks

2. pickListMenu

.pickListTreeMenu,
.pickListMenu {
  font-family: Roboto-Light-Vivid;
  color: #444444;
  font-size: 12px;
  border: 1px solid #ecf3fb;
  background-color: #ffffff;
}

which lacks font-family fallbacks and has another definition with a different background-color:

.pickListMenu {
  border: 1px solid #d0d0d0;
  padding: 0px;
  background-color: #ffffff;
  -moz-box-shadow: none;
  -webkit-box-shadow: none;
  box-shadow: none;
  -moz-border-radius: 2px;
  -webkit-border-radius: 2px;
  border-radius: 2px;
}

3. windowHeaderText

.portletHeader .windowHeaderText {
  color: #444444;
  font-family: Roboto-Light-Vivid;
  font-size: 18px;
  line-height: 18px;
  padding-left: 3px;
}

again, no fallbacks and different color in another definition:

.windowHeaderText {
  color: #ffffff;
  font-family: Roboto-Light-Vivid, Arial, Helvetica, sans-serif;
  font-size: 14px;
  font-weight: bold;
  line-height: 17px;
  padding: 0px 0px 0px 5px;
}

[Isomorphic]

Thanks Claudio - for reference, in general you're seeing a default block, which would have fallback fonts for example, and a customized-block from Shiva's custom file, which would be the block later in your skin_styles file.

The custom blocks were mostly unnecessary and we've addressed them all for today's builds, dated August 25.

[claudiobosticco]

I see the changes, thank you very much