dateChooserButton with duplicated border style

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-10-06/Enterprise Development Only (built 2024-10-06)

Hello, I just noticed that the dateChooserButton style for flat skins contains 2 definitions for border:

....
  border: 0px solid #ffffff;
  font-family: Roboto-Light-Vivid, Arial, Helvetica, sans-serif;
  font-size: 11px;
  font-weight: bold;
  border: none;
...

[Isomorphic]

Thanks Claudio - we've fixed this for tomorrow's builds.

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-10-09/AllModules Development Only (built 2024-10-09)

I still see it, I'll retry tomorrow.

[Isomorphic]

hi Claudio - part of the checkin for this fix had been missed - you'll find the extra border-setting removed in today's builds, dated October 13.

[claudiobosticco]

SmartClient Version: SNAPSHOT_v13.1d_2024-10-13/Enterprise Deployment (built 2024-10-13)

Now I see it, thanks

[claudiobosticco]

but I just noticed that there's also border-radius: none in dateChooserHeader style, which I don't think is a valid value:

.dateChooserHeader {
  background: #ffffff;
  padding: 0px;
  border-radius: none;
}

[claudiobosticco]

I also noticed that if I re-export my custom skin with the skin editor, using the latest build, but without making any changes to the skin settings, the exported skin doesn't pick up the fix.
I still see the duplicated border style.

However, if I make a modification to the skin, then the exported skin has the corrected CSS.

is it expected?

[Isomorphic]

We've fixed the border-radius, which was being assigned the border variable.

Right now, yes, if you want to pick up modifications to the underlying skin, you need to re-Save your skin in the Skin Editor, to re-compile its skin_styles.css. You can press Ctrl-Alt-S to enable the save button without changing anything.

[claudiobosticco]

I see the fix for the border-radius, thanks.

Thanks also for the Ctrl-Alt-S hint, maybe a hover on the button would be useful