problem with Selection.dataArrived()

[senordhuff]

Hi, we were seeing the following error in our application

16:07:54.885:XRP5:WARN:Log:TypeError: Cannot call method '$52z' of undefined
Stack from error.stack:
    Selection.dataArrived()
    eval()
    ResultSet._doneDataArriving()
    isc.B.push.isc.A.fetchRemoteDataReply()
    [c]Class.fireCallback()
    [c]Class.fireCallback()
    DataSource.fireResponseCallbacks()
    DataSource._completeResponseProcessing()
    DataSource._handleSCServerReply()
    [c]Class.fireCallback()

The following patch resolved it which is pretty simple

	if (window.isc &&  isc.version.startsWith("v9.0")){
	    isc.Selection.getPrototype().addProperties({

	    	//9/3/13..NULL CHECK on this.data
	        dataArrived:function (_1,_2,_3){if(this.data==null || this.data.$52z()){return}
	        this.dataChanged(null,null,null,null,null,_3)}

	    })
		
	}

[Isomorphic]

Thanks for the explanation.
We'll roll this null check into the framework and let you know when it's in.
We haven't encountered this exception ourselves. Could you show us a way to reproduce it? We want to be sure there isn't a deeper framework issue which needs addressing

Thanks
Isomorphic Software

[senordhuff]

Thank you. Unfortunately, it is just too time-consuming to try to reproduce a problem like this outside of our application because it involves a lot of complex interactions between different components.

[Isomorphic]

Fair enough - consider this a caveat though: Without seeing what's going on, we're adding a bit of a "blind" check for a problem we've never seen with valid usage.
That may indicate that there's a deeper framework bug we're unaware of which will bite you, or it may indicate a usage issue within your app. Or of course it may all be completely valid and we may have been missing a simple check.
In short, we can't guarantee you don't have a deeper problem that will cause other visible issues in your app, since we never got to the bottom of the underlying cause of this issue.

Regards
Isomorphic Software

[senordhuff]

I completely understand. I also realize you are expanding these comments for the benefit of someone else who may stumble upon this thread. Whenever a problem like this causes serious problems in our application, I do indeed spend the time to reproduce so you can investigate. So, I have to consider on a case by case basis when to just patch and move on vs reproduce for you.

[Isomorphic]

Understandable, thanks for trying.

We've now added this null check and it should be available in the coming nightly builds of 9.0p and 9.1d

Regards
Isomorphic Software