Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    Listgird - filterExpressions with filterOnKeypress issues

    I have found two issues with enabled 'filterExpressions' and 'filterOnKeypress' on current Smartclient 9.1

    1. When trying to enter 'inSet' expression, if user stops typing after '=' sign for a longer period than 'fetchDelay', it will be expanded into '==='. Filter expression will not work correctly after completion without deleting those extra two signs.

    How to reproduce:
    - Open LiveGrid example: http://www.smartclient.com/docs/9.1/a/system/reference/SmartClient_Explorer.html#fetchOperationFS

    - Enable filterEditor, filterExpressions and filterOnKeyPress:
    Code:
    isc.ListGrid.create({
        ID:"dsListGrid",
        width: "100%",
        height: "100%",
        autoFitData: "horizontal",
        autoFetchData: true,
        dataSource: "supplyItem" ,
        showFilterEditor: true,
        allowFilterExpressions:true,
        filterOnKeypress:true
    });
    - Type single '=' sign into filter editor for 'SKU' column and wait for standard 300ms. You should see something similar to attached screenshot.

    It's also pretty hard to delete those signs with Backspace key when there are not parentheses present after '=' sign, but this is exactly what our users are trying to do first and they are getting frustrated with this. It looks like 'number' type columns are not affected by this.

    2. The second issue is with deleting expressions with parentheses (correct one, with single '=' sign). You can't delete closing parenthesis (either with Backspace or Delete key) until you delete opening first. Reproducible on the same example as first issue. Type into 'SKU' filter
    Code:
     =(45300|90600)
    ant try to delete it with Backspace when cursor is at the end of expression.

    I'm getting this issues on Chrome 33/Firefox 28 running on Windows 7.
    Attached Files

    #2
    We've added automatic detection for incomplete expressions while typing - from builds dated May 3, you should find you can now type complex expressions without a fetch happening until the expression is complete and valid.

    Comment


      #3
      Expressions works better, thanks.
      But there is a new issue. When expression is deleted by selecting whole string and pressing Delete key, fetch is not performed until Enter key is pressed. In previous version it worked without Enter.

      Another issue: Checkbox filter doesn't work at all without pressing Enter key after change

      Tested on: "SmartClient Version: v9.1p_2014-05-11/PowerEdition Development Only (built 2014-05-11)"
      Last edited by ajr; 14 May 2014, 02:32.

      Comment


        #4
        This has been fixed for builds dated May 16 and later

        Comment


          #5
          It works nicely now, thanks.
          There is one more, cosmetic issue, with filters. Boolean columns have filter editor checkbox misaligned to left, when placed as last column. Screenshot attached.
          To reproduce enable filterEditor in Live Grid example (9.1 version) and move 'In Stock' column to the right.

          Latest version I checked, still with this issue present is: SmartClient_v91p_2014-06-08_PowerEdition
          Attached Files

          Comment


            #6
            There's still an issue with isNull (#) and isNotNull (!#) expressions. filterOnKeypress doesn't work with them without pressing Enter key.

            Comment


              #7
              null and notNull are fixed for tomorrow's builds - the cosmetic column-alignment issue is noted

              Comment

              Working...
              X