bug in Calendar.addEventOrUpdateEventFields

[claudiobosticco]

SmartClient Version: v10.0p_2014-11-16/EVAL Deployment (expires 2015.01.15_12.11.41) Licensed to: Isomorphic Software (#ISC_EVAL_NIGHTLY)

Chrome on OSX

I think I've just found a bug in Calendar.addEventOrUpdateEventFields, at least for the case editStyle == "time" (line 12224 of modules-debug/ISC_Calendar.js), where the:
var sAMPM = values["startAMPM"]

is not used, so I can't change the date of an event from AM to PM.

If I change the code like this:

....
    } else if (editStyle == "time") {
        var sAMPM = values["startAMPM"],
            sHrs = cal.twentyFourHourTime ? cal._to24HourNotation(values["startHours"], sAMPM)
                    : values["startHours"],
            sMins = values["startMinutes"]
        ;

        if (!cal.twentyFourHourTime) {
            sHrs = cal._to24HourNotation(sHrs, sAMPM);
            // handle the case where end date is 12am, which is valid, as this
            // is considered the end of the current day
            if (sHrs == 0) sHrs = 24;
        }
....

the problem seems fixed.

[Isomorphic]

Please show the code that produces the error

[claudiobosticco]

you could try the #databoundCalendar sample in the showCase:
1. click on 'Airport run' event
2. click 'Edit Details'
3. change both 'From' and 'To' select from 'am' to 'pm'
4. click 'Save Event'

you'll see that the 'From' time hasn't changed.

[claudiobosticco]

SmartClient Version: v10.0p_2014-12-17/EVAL Development Only (expires 2015.02.15_07.40.12) Licensed to: Isomorphic Software (#ISC_EVAL_NIGHTLY)

Hello, any updates? The bug's still there v10.0p_2014-12-17.

[Isomorphic]

This is fixed for builds dated December 19 and later.

[claudiobosticco]

SmartClient Version: v10.0p_2014-12-21/EVAL Development Only (expires 2015.02.19_16.58.04) Licensed to: Isomorphic Software (#ISC_EVAL_NIGHTLY)

verified, thank you very much