Announcement

**Isomorphic** · 31 Jan 2019, 08:47

This indicates the inSet operator's processValue() function is being passed null.

In the absence of a test-case, please try this patch code at the top of your app - let us know if that works for you and we'll add the change to the framework.

Code:

isc.DataSource.getSearchOperator("inSet").processValue = function (value, ds) {
    if (value == null) return null;
    return value.split(this.valueSeparator);
}

**stonebranch2** · 31 Jan 2019, 09:09

Hi Isomorphic,

Will give it a try.

In the code above, is there an erroneous bracket here?

"inSet"]

Thanks

**Isomorphic** · 31 Jan 2019, 09:26

Yes, sorry, drop the closing square bracket.

If this doesn't work for you, log out the value passed in - it's possible it may already be an array, although that is unexpected.

**stonebranch2** · 31 Jan 2019, 10:06

Quick followup.

It would appear I am getting the following error when applying that code.

TypeError: isc.DataSource.getSearchOperator is not a function

Thanks

**Isomorphic** · 31 Jan 2019, 10:10

Ah yes, sorry, it's an instance method - for this quick test, you can call it on the DS your grid is using, since it returns an element from a static array.

**stonebranch2** · 31 Jan 2019, 10:10

Should it be something like the following?

Code:

        isc.DataSource.getSearchOperators()["inSet"].processValue = function (value, ds) {
            if (value == null) return null;
            return value.split(this.valueSeparator);
        }

**stonebranch2** · 31 Jan 2019, 10:15

The following code:

Code:

        isc.DataSource.getSearchOperators()["inSet"].processValue = function (value, ds) {
            alert("type: " + (typeof value) + ", value: " + value);
            alert("type: " + (typeof this.valueSeparator) + ", valueSeparator: " + this.valueSeparator);
            if (value == null) return null;
            return value.split(this.valueSeparator);
        }

Produces the following output:

Code:

type: number, value: 190
type: string, valueSeparator: |

Code:

13:14:28.167:MUP7:WARN:Log:TypeError: value.split is not a function
Stack from error.stack:
    unnamed() @ :104:14
    FormItem.setValue() @ xxxx/sc/modules/ISC_Forms.js:1100:142
    Class.invokeSuper() @ xxxx/sc/modules/ISC_Core.js:313:158
    SelectItem.setValue() @ xxxx/sc/modules/ISC_Forms.js:2298:907
    DynamicForm.setItemValues() @ xxxx/sc/modules/ISC_Forms.js:425:159
    DynamicForm._addItems() @ xxxx/sc/modules/ISC_Forms.js:284:42
    DynamicForm.addItems() @ xxxx/sc/modules/ISC_Forms.js:277:84
    FilterClause.updateValueItems() @ xxxx/sc/modules/ISC_DataBinding.js:2981:1
    FilterClause.operatorChanged() @ xxxx/sc/modules/ISC_DataBinding.js:2980:301
    changed() @ xxxx/sc/modules/ISC_DataBinding.js:3004:1308
    FormItem.handleChanged() @ xxxx/sc/modules/ISC_Forms.js:1207:17
    FormItem.storeValue() @ xxxx/sc/modules/ISC_Forms.js:1206:18
    FormItem._updateValue() @ xxxx/sc/modules/ISC_Forms.js:1203:63
    SelectItem.updateValue() @ xxxx/sc/modules/ISC_Forms.js:2298:41
    SelectItem.changeToValue() @ xxxx/sc/modules/ISC_Forms.js:2289:86
    SelectItem.pickValue() @ xxxx/sc/modules/ISC_Forms.js:2333:1
    itemClick() @ xxxx/sc/modules/ISC_Forms.js:2013:1
    recordClick() @ xxxx/sc/modules/ISC_Forms.js:2006:136
    ListGrid.rowClick() @ xxxx/sc/modules/ISC_Grids.js:1631:17
    Class.invokeSuper() @ xxxx/sc/modules/ISC_Core.js:313:89
    Class.Super() @ xxxx/sc/modules/ISC_Core.js:305:165
    rowClick() @ xxxx/sc/modules/ISC_Forms.js:2001:191
    anonymous() @ xxxx/sc/modules/ISC_Core.js line 83 > Function:4:105
    GridRenderer._rowClick() @ xxxx/sc/modules/ISC_Grids.js:569:178
    Class.invokeSuper() @ xxxx/sc/modules/ISC_Core.js:313:89
    Class.Super() @ xxxx/sc/modules/ISC_Core.js:305:165
    GridBody._rowClick() @ xxxx/sc/modules/ISC_Grids.js:638:71
    GridRenderer.click() @ xxxx/sc/modules/ISC_Grids.js:567:162
    Canvas.handleClick() @ xxxx/sc/modules/ISC_Core.js:3500:395
    [c]EventHandler.bubbleEvent() @ xxxx/sc/modules/ISC_Core.js:2136:82
    [c]EventHandler.handleClick() @ xxxx/sc/modules/ISC_Core.js:1974:47
    EventHandler._handleMouseUp() @ xxxx/sc/modules/ISC_Core.js:1959:8
    [c]EventHandler.handleMouseUp() @ xxxx/sc/modules/ISC_Core.js:1950:54
    [c]EventHandler.dispatch() @ xxxx/sc/modules/ISC_Core.js:2223:76
    anonymous() @ xxxx/sc/modules/ISC_Core.js line 83 > Function:3:95

**stonebranch2** · 31 Jan 2019, 10:26

Hi Isomorphic,

Is it safe for us to use the following workaround?

Code:

        isc.DataSource.getSearchOperators()["inSet"].processValue = function (value, ds) {
            if (value == null) return null;
            if (typeof value === "number"){
                return (value + "").split(this.valueSeparator);
            } else {
                return value.split(this.valueSeparator);
            }
        }

That appears to resolve our issue, however, just want to make sure it isn't going to introduce a regression somewhere else.

If you have a more appropriate workaround, please let me know.

Thanks

**Isomorphic** · 31 Jan 2019, 10:32

Please confirm
- the field data and formItem type
- the value in the field when you change operator (which we assume is via the operatorMenu?)
- whether the grid has allowFilterExpressions set to true

**Isomorphic** · 31 Jan 2019, 10:34

You can use it for today as a workaround, but we'll fix it for tomorrow's builds.

**stonebranch2** · 31 Jan 2019, 10:47

It would be a type="integer".

It has a value map of integer value to display name.

The form item type would be a SelectItem.

<div id="isc_KI" $89="isc_SelectItem_4" $9a="$9d" class="selectItemText" style="width:273px;height:12px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;line-height:-moz-block-height;" tabindex="4153" role="option">Cancelled, Failed, Finished</div>

Yes, the operator is changed from the user interface using the operator drop-down.

The value in there is 190 at the time of changing the operator. This value is of type number, as shown in the earlier post.

With respect allowFilterExpressions, we don't use filter expressions, however, this is happening on the filter builder, so wasn't exactly sure what you meant by grid.

**Isomorphic** · 1 Feb 2019, 01:41

A fix for this issue is now in - please retest with a build dated February 2 or later.

**stonebranch2** · 1 Feb 2019, 07:35

Thank you

Announcement

TypeError: _26.split is not a function

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment