ISC_Calendar warning in console, "unreachable code"

[mathias]

13.1-p20250205

Every time the page loads, there's a warning in the console:

unreachable code after return statement

ISC_Calendar.js 888:88

Sounds like a bug, thought i'd let you know.

Cheers

[Isomorphic]

We aren't seeing this issue in Feburary 5 builds, or in the latest ones, and there doesn't seem to be any unreachable code at that location in ISC_Calendar.js.

There was a tweak on December 18 last year to address an unreachable-code issue in Calendar - that issue was in an internal method called selectChosenDateCells(), which is no longer in the framework.

You could click the link in the warning to see which code the report is coming from - if it's not in selectChosenDateCells(), please let us know.

[mathias]

First, just to make sure that i'm not using the wrong file. the calendar.js that shows the warning has

SmartClient Ajax RIA system
Version v13.1p_2025-02-05/Pro Deployment (2025-02-05)

at the top.

OK, i'm not great at this, but if i go into the Firefox debugger, this is the section where row 808 is supposed to be:

let me know if this useless and you want me to do something else :)

EDIT: the "808:88" that the warning logs is this part of the paste below:

if(this.isTimeline()){var _11=(isc.DateUtil.compareLogicalDates(_1,_2)!=0);if(_11){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+

return},isc.A.visibilityChanged=function isc_Calendar_visibilityChanged(_1){if(!_1)this.hideEventDialog()},isc.A.showEventEditor=function isc_Calendar_showEventEditor(_1,_2){if(_2==null)_2=(_1==null);this.$53j(_1,_2)},isc.A.showNewEventEditor=function isc_Calendar_showNewEventEditor(_1){this.showEventEditor(_1,true)},isc.A.$53j=function isc_Calendar__showEventEditor(_1,_2){var _3=this.getEventEditorLayout();if(!_3.isDrawn()){_3.setVisibility(isc.Canvas.INHERIT);_3.draw()}
_3.setWidth(this.mainView.getVisibleWidth());_3.setHeight(this.mainView.getVisibleHeight());_3.setPageLeft(this.mainView.getPageLeft());_3.setPageTop(this.getPageTop());_3.isNewEvent=_2;_3.view=this.getSelectedView();var _4=this.getDateEditingStyle();this.eventEditor.dateEditingStyle=_4;this.eventEditor.rebuildFieldList();if(_1){_3.setEvent(_1)}else{this.eventEditor.clearValues();_3.setTitle(this.newEventWindowTitle);if(this.eventDialog&&this.eventDialog.isVisible()){if(this.eventEditorFields){_3.items[0].setCustomValues(this.eventDialog.items[0].getCustomValues())}
var _5=this.eventDialog.items[0].getValue(this.nameField);var _6=this.eventDialog.items[0].getItem(this.laneNameField);var _7=_6?_6.getValue():null;var _8=new Date();_3.setDate(_8,this.eventDialog.currentEnd,_5,_7)}}
this.hideEventDialog();var _9=this.canEditEvent(_1,this.getSelectedView());this.eventEditor.setDisabled(!_9);_3.saveButton.setDisabled(!_9);_3.show()},isc.A.$53k=function isc_Calendar__getEventDialogTitle(_1,_2,_3){var _4=isc.DateUtil.getShortDayNames(),_5=isc.DateUtil.getShortMonthNames(),_6=isc.Time.toShortTime(_1,this.timeFormatter),_7=isc.Time.toShortTime(_2,this.timeFormatter),_8;var _9=this.isLongEvent(_3,true);var _10=!!_3[this.allDayField];if(_9){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+(!_10?", "+_6:"")+" - "+_4[_2.getDay()]+", "+_5[_2.getMonth()]+" "+_2.getDate()+(!_10?", "+_7:"");return _8}else if(_10){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+" ["+this.eventAllDayFieldTitle+"]";return _8}
_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+" - "+_6+" - "+_7;return _8;if(this.isTimeline()){var _11=(isc.DateUtil.compareLogicalDates(_1,_2)!=0);if(_11){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+", "+_6+" - "+_4[_2.getDay()]+", "+_5[_2.getMonth()]+" "+_2.getDate()+", "+_7;return _8}}