ISC_Calendar warning in console, "unreachable code"

[mathias]

13.1-p20250205

Every time the page loads, there's a warning in the console:

unreachable code after return statement

ISC_Calendar.js 888:88

Sounds like a bug, thought i'd let you know.

Cheers

[Isomorphic]

We aren't seeing this issue in Feburary 5 builds, or in the latest ones, and there doesn't seem to be any unreachable code at that location in ISC_Calendar.js.

There was a tweak on December 18 last year to address an unreachable-code issue in Calendar - that issue was in an internal method called selectChosenDateCells(), which is no longer in the framework.

You could click the link in the warning to see which code the report is coming from - if it's not in selectChosenDateCells(), please let us know.

[mathias]

First, just to make sure that i'm not using the wrong file. the calendar.js that shows the warning has

SmartClient Ajax RIA system
Version v13.1p_2025-02-05/Pro Deployment (2025-02-05)

at the top.

OK, i'm not great at this, but if i go into the Firefox debugger, this is the section where row 808 is supposed to be:

let me know if this useless and you want me to do something else :)

EDIT: the "808:88" that the warning logs is this part of the paste below:

if(this.isTimeline()){var _11=(isc.DateUtil.compareLogicalDates(_1,_2)!=0);if(_11){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+

return},isc.A.visibilityChanged=function isc_Calendar_visibilityChanged(_1){if(!_1)this.hideEventDialog()},isc.A.showEventEditor=function isc_Calendar_showEventEditor(_1,_2){if(_2==null)_2=(_1==null);this.$53j(_1,_2)},isc.A.showNewEventEditor=function isc_Calendar_showNewEventEditor(_1){this.showEventEditor(_1,true)},isc.A.$53j=function isc_Calendar__showEventEditor(_1,_2){var _3=this.getEventEditorLayout();if(!_3.isDrawn()){_3.setVisibility(isc.Canvas.INHERIT);_3.draw()}
_3.setWidth(this.mainView.getVisibleWidth());_3.setHeight(this.mainView.getVisibleHeight());_3.setPageLeft(this.mainView.getPageLeft());_3.setPageTop(this.getPageTop());_3.isNewEvent=_2;_3.view=this.getSelectedView();var _4=this.getDateEditingStyle();this.eventEditor.dateEditingStyle=_4;this.eventEditor.rebuildFieldList();if(_1){_3.setEvent(_1)}else{this.eventEditor.clearValues();_3.setTitle(this.newEventWindowTitle);if(this.eventDialog&&this.eventDialog.isVisible()){if(this.eventEditorFields){_3.items[0].setCustomValues(this.eventDialog.items[0].getCustomValues())}
var _5=this.eventDialog.items[0].getValue(this.nameField);var _6=this.eventDialog.items[0].getItem(this.laneNameField);var _7=_6?_6.getValue():null;var _8=new Date();_3.setDate(_8,this.eventDialog.currentEnd,_5,_7)}}
this.hideEventDialog();var _9=this.canEditEvent(_1,this.getSelectedView());this.eventEditor.setDisabled(!_9);_3.saveButton.setDisabled(!_9);_3.show()},isc.A.$53k=function isc_Calendar__getEventDialogTitle(_1,_2,_3){var _4=isc.DateUtil.getShortDayNames(),_5=isc.DateUtil.getShortMonthNames(),_6=isc.Time.toShortTime(_1,this.timeFormatter),_7=isc.Time.toShortTime(_2,this.timeFormatter),_8;var _9=this.isLongEvent(_3,true);var _10=!!_3[this.allDayField];if(_9){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+(!_10?", "+_6:"")+" - "+_4[_2.getDay()]+", "+_5[_2.getMonth()]+" "+_2.getDate()+(!_10?", "+_7:"");return _8}else if(_10){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+" ["+this.eventAllDayFieldTitle+"]";return _8}
_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+" - "+_6+" - "+_7;return _8;if(this.isTimeline()){var _11=(isc.DateUtil.compareLogicalDates(_1,_2)!=0);if(_11){_8=_4[_1.getDay()]+", "+_5[_1.getMonth()]+" "+_1.getDate()+", "+_6+" - "+_4[_2.getDay()]+", "+_5[_2.getMonth()]+" "+_2.getDate()+", "+_7;return _8}}

[mathias]

Hey guys, did you get a chance to look at this? i still see it on every page load.

[Isomorphic]

Unfortunately, we don't see this issue and nobody else has reported it.

We'll need a test-case to reproduce.

[claudiobosticco]

SmartClient Version: v13.1p_2025-04-02/Enterprise Deployment (built 2025-04-02)

Hello, I’m actually seeing this when my application loads:

unreachable code after return statement ISC_Calendar.js:19085:5

the file it the modules-debug version, inside the _getEventDialogTitle method:

[Isomorphic]

Thanks guys - this one's been fixed for today's builds.

[mathias]

Right. that's good, but i'm not sure it's the same thing as mine?

Since reporting this, i updated to see if it went away which it hasn't for me as mentioned.

i now use v13.1p_2025-03-23, and the warning has now moved to ISC_Calendar.js:813:88
...

There's no way i'll have time to create an entire test case for something that happens when your files load. But i did paste the warnings and the relevant JS and had a quick chat with Chat GPT :)

Here's what it said:

Here’s the problematic code (line 813):

return},isc.A.visibilityChanged=function isc_Calendar_visibilityChanged(_1){if(!_1)this.hideEventDialog()}

Problem:
There’s a return with nothing after it, followed by more code on the same line. The code after return is unreachable.

Looks like minified SmartClient code. The line should be split:
return;
}, isc.A.visibilityChanged = function(...) { ... }

[Isomorphic]

Yes, the issue just addressed is the same one you reported, and it will be fixed in today's builds of 13.1 and later releases.

The output from ChatGPT is unfortunately bogus - the method it pointed to has only one line of code, which isn't a return statement, and the methods around it in the source-code are fine.

[claudiobosticco]

SmartClient Version: v13.1p_2025-04-03/Enterprise Deployment (built 2025-04-03)

I can confirm that I don't see the warning anymore