Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

  • #16
    Hi Isomorphic,

    yes, please try this in the SmartClient showcase:
    Code:
    isc.DynamicForm.create({
        ID: "form1",
        titleOrientation: "top",
        canEdit: false,
        width: 620,
        colWidths: ["*", "*"],
        fields: [
            {name: "text", title:"Text", type:"text", hint: "A plain text field", wrapHintText: false,
            icons: [{
                name: "tel",
                src: "blank", // if inline icons are not supported by the browser, revert to a blank icon
                inline: true,
                text: "✆",
                baseStyle: "telIcon"
            }]},
            {name: "link", title:"Link", type:"LinkItem", value:"https://forums.smartclient.com/", applyHeightToTextBox: null,
            icons: [{
                name: "tel",
                src: "blank", // if inline icons are not supported by the browser, revert to a blank icon
                inline: true,
                text: "✆",
                baseStyle: "telIcon"
            }]}
        ]
    });
    Best regards
    Blama

    Comment


    • #17
      Hi Isomorphic,

      can you have a look at the sample code from #16? It shows the issue I displayed before in #14 with a screenshot.

      Best regards
      Blama

      Comment


      • #18
        We do see this issue, but we won't be able to get to it until after the imminent 12.0 release - we'll update here when it's fixed.

        Comment


        • #19
          Hi Isomorphic,

          can you have a look at this one now as well?

          Thank you & Best regards
          Blama

          Comment


          • #20
            Apologies for the delay - we'll get to this in the next few days and update here when it's fixed.

            Comment


            • #21
              Hi Isomorphic,

              I just retested the sample from #16 with v11.1p_2018-04-27 and it still looks the same.
              Click image for larger version

Name:	LinkItem.png
Views:	1
Size:	8.6 KB
ID:	253022

              Best regards
              Blama

              Comment


              • #22
                Yes, apologies for the delay - we'll be adding new code shortly to apply an outer table that enforces the textBoxHeight and a v-centered, l-offset link, which should deal with these two situations.

                Comment


                • #23
                  Hi Isomorphic,

                  I just retested the sample from #16 with v11.1p_2018-05-14 and it still looks the same.

                  Best regards
                  Blama

                  Comment


                  • #24
                    Yes, apologies - we'll try to make these changes today.

                    Comment


                    • #25
                      These changes have just hit and you can test them out in builds dated May 17 and later.

                      Comment


                      • #26
                        Hi Isomorphic,

                        I retested with v11.1p_2018-05-17 and the code from #16 and still do see a difference to #21. The text is now not over the icon, not the positioning is still not correct. Please see this screenshot:

                        Click image for larger version

Name:	LinkItem positioning.png
Views:	1
Size:	5.3 KB
ID:	253231
                        Best regards
                        Blama

                        Comment


                        • #27
                          Hmm, a quick test shows both problems fixed in 12.0+ but we do indeed still see the height issue in 11.1 - we'll take a look just now.
                          Last edited by Isomorphic; 17th May 2018, 07:02.

                          Comment


                          • #28
                            Ok, this has been fixed now - the problem was that LinkItem specified height:null by default, but it should no longer do that, instead inheriting the height from TextItem - we didn't notice this in testing because we built an offline sample based on this test-case and an earlier one of yours, which happened to specify a global height of 30 for LinkItems.

                            If you do the same in your most recent example, setting a global height for LinkItems, that will emulate the fix we just applied, and should behave as you expect - otherwise, you can test the fix from tomorrow's builds.

                            Comment


                            • #29
                              Hi Isomorphic,

                              with an added height:30, for the 2nd item it does look good now with today's build as well in 6.1p.

                              Thank you & Best regards
                              Blama

                              Comment


                              • #30
                                Hi Isomorphic,

                                using v11.1p_2018-05-22 this now looks good for me with the testcase from #16 (just added value for the 1st FormItem).

                                Click image for larger version

Name:	IssueSolved.png
Views:	1
Size:	6.8 KB
ID:	253293

                                I'm sure this will fix the issue in my application as well.

                                Best regards
                                Blama

                                Comment

                                Working...
                                X