Toolstip issue in FF 18

[MarcusZ]

Hi,
i've got an optical issue with toolstrips in firefox 18.0.
I've got a toolstrip with two buttons separated from a toolstripseparator.
If you've a look at the screenshot you'll see the result. The two buttons will move up
This only occurs when the button has an icon.
If the cursor was moved above one button it will move down to it's proper place.
The second problem is the separator, it does increase the space between the two buttons a little bit to much.

I'm using html doctype 5 and smartclient version "v8.3p_2013-01-09/Pro Deployment "

Here is my example code

isc.ToolStrip.create(
       {
        "width":"100%",
        "leaveScrollbarGap":false,
        "members":
        [ isc.Button.create(
          {
           "overflow":"visible",
           "tabIndex":0,
           "title":"New",
           "icon":"icons/16/icon_add_files.png",
           "showDisabledIcon":false
          }
          ),
		 isc.ToolStripSeparator.create(
          {
          }
          ),
         isc.Button.create(
          {
           "overflow":"visible",
           "tabIndex":0,
           "title":"Find",
           "icon": "icons/16/find.png"
          }
          )
        ]
});

Regards Marcus

[bakosa]

We noticed the same (among other visual problems). First we though it's some kind of caching issue, as F5 helped, but the problem came back later.

[Isomorphic]

Thanks for the test case. We don't see a behavior exactly like the screenshot - we don't see the vertical misalignment but we do see the extra space next to the spacer (which does indeed seem to intermittently go away on reload).

We're looking into this effect and will let you know when we have any more information on it

Regards
Isomorphic Software

[felipe_1]

problems in FF18

We noticed the same (among other visual problems). First we though it's some kind of caching issue, as F5 helped, but the problem came back later.

Same here, also tabs and toolbar look as if they were "zoomed out", going back to their size when the mouse is hovered over those elements

[Isomorphic]

We have made a change which we believe will address the rendering problems we've experienced in Firefox 18. Please try the next nightly build on the SmartGWT 3.0p, 3.1p or 4.0d branch, or SmartClient 8.2p, 8.3p or 9.0d branch, dated January 11 2013 or greater.

If you continue to experience problems with this browser, please provide us with specific descriptions of the problem(s) you're seeing and steps to reproduce.

Thanks and Regards
Isomorphic Software

[Isomorphic]

We have made some additional changes to resolve some remaining issues with rendering in Firefox 18.

Please try the next nightly build (dated Jan 12).

This fix will be applied to the following branches

SmartGWT: 2.5p, 3.0p, 3.1p, 4.1d
SmartClient: 8.1p, 8.2p, 8.3p, 9.0d

Regards
Isomorphic Software

[MarcusZ]

Hi,
the issue i'd reported is solved in "v8.3p_2013-01-14/Pro Deployment". Thanks for that.
But it was just replaced by another bug.
It seams that the toolstrip doesn't consider the width of the previous button,
when drawing it's members, as you can see in the screenshot.

[Isomorphic]

Thanks for the notification. We're taking a look.

Isomorphic Software

[gabbag81]

Possible fix

After a couple of tries I noticed that there is a problem in setting properly the width of the items in the ToolStrip. I get it working properly setting manually the width of the toolstrip buttons and setting for all the buttons the property inherentWidth to false in a native function. I have a class inheriting toolStrip and I override addButton:

@Override
	public void addButton(ToolStripButton button) {
		if(button.getTitle() == null||button.getTitle().equals("")) {
			button.setIconSpacing(0);
			button.setLabelHPad(3);
			button.setWidth("25px");
		} else if (button.getIcon() == null) {
			button.setLabelHPad(7);
		}

		addMember(button);

		applyiWidth(button.getJsObj());
	}

	private static native void applyiWidth(JavaScriptObject itemJS)/*-{

		itemJS.inherentWidth =false;

	}-*/;

The addButton method is the superclass one with width of 25px if the title is null or "". If the title is specified you have to set manually the width.

I had to create an utility method to have separator with a width:

	public static ToolStripSeparator getSeparator()
	{
		ToolStripSeparator sep = new ToolStripSeparator();
		sep.setWidth ("20px");
		sep.setHeight("20px");
		return sep;
	}

I have SmartGWT: 2.5p. Tested in firefox 18 and IE9

[acarur01]

Is there a list if issues that have been found for FF18? Our UI is now completely broken - before I updated to the latest build for 8.2p, the only issue was padding of elements but now all of our menus are generated on top of each other.

[Isomorphic]

We are aware of, and working hard to resolve the Firefox 18 issues.
We have a pretty clear picture of the problem - In this release Firefox changed the way it reports sizes of unloaded images in a way that broke sizing of multiple UI elements on initial load.

We made a change to address this - which did appear to take care of the problem and worked well in Firefox / Mac, but introduced a more serious fundamental problem in Firefox / Windows (which results in misreported sizing everywhere and the overlapping UI you describe). We are trying to come up with a solution that will address both issues on all platforms and will update the thread as soon as we have something. We'd very much like to have this resolved for the next nightly build. If we can't get a full solution in place we will at least update with a partial solution to get rid of the worst of the rendering bugs temporarily while we continue to work on this.

Regardless - we will follow up when we have more information.

[Isomorphic]

A quick update to let you know we have made some changes to mitigate many of the rendering issues in Firefox 18.
Things should look significantly better in the Jan 16th nightly.
(8.3p/3.1p, 8.2p/3.0p and 8.1p/2.5p branches).

We are aware that there are still rendering issues with some components and will continue to work on them over the next few days. We will follow up again as we make progress, but please feel free to try the next nightly build and let us know if there are any specific issues you're encountering so we can be sure they don't get missed.

Regards
Isomorphic Software

[MarcusZ]

Hi,
the issue with the toolbar is solved in smartclient version "v8.3p_2013-01-16/Pro Deployment"
and there aren't any further issues so far.
Thanks for the quick fix

Regards Marcus

[acarur01]

Most of the menu issues we were experiencing yesterday are fixed with 1-16 build but there are still a couple I believe padding issues that are not fixed until we refresh the page - it results in some menus being tucked away beyond the parent layout. I'll wait for more updates. Thanks!

[Isomorphic]

Please try the next nightly build, dated Jan 18
We believe these issues (including the breakage of closeable tabs) are now resolved

If you are still seeing rendering, or other problems, please let us know, and rest assured we will do our best to resolve things very rapidly.

Regards
Isomorphic Software