12.0p BatchUploader bug after Commit with default deferRemoval: null (results in true)

[Blama]

Hi Isomorphic,

similar to here there is a problem with a default deferRemoval: null using current v12.0p_2019-12-14.

The records marked as removed are transferred nevertheless. Steps to reproduce:

• Switch to mode "Retain"
• Upload file (4 good records, 3 validation errors)
• Remove all records, leave only one without validation error
• Commit
• Expected result: 1 Add-operation, other records removed or present and still in deferRemoval-state
• Actual result: 4 Add operations for records w/o + validation error plus 3 with validation errors in grid in normal state

Modified sample:

isc.BatchUploader.create({
    ID:"uploader",
    height: 700,
    width: "100%",
    uploadDataSource: supplyItemCustom,
    uploadFormProperties: {
        titleWidth: 110
    },
    gridProperties: {
        height: 400,
        canRemoveRecords: true
    }
});

isc.DynamicForm.create({
    ID: "partialCommitsForm",
    items: [
        {
            name:"partialCommits", 
            wrapTitle: false,
            title:"Partial Commit Mode", 
            type:"select", 
            defaultValue: "prompt",
            valueMap:{
                allow: "Allow", 
                prevent: "Prevent", 
                prompt: "Prompt",
                retain: "Retain"
            },
            changed : function(form, item, value) {
                uploader.partialCommit = value;
            }
        }
    ]
});

isc.VStack.create({
    width:"100%",
    layoutMargin:10,
    membersMargin: 10,
    members:[
        partialCommitsForm,
        uploader
    ]
});

Best regards
Blama

[Isomorphic]

Apologies for the delay. We are working on this and will follow up when we unnecessary changes will be made.

[Isomorphic]

This is fixed and available for download in nightly builds since Jan 16.

[Blama]

Hi Isomorphic,

I retested online with v12.0p_2020-01-17 and this changed, but is still buggy if you fix error and then commit again:

• Upload test file to original sample
• Click Commit, Click OK
• 3 records with validation errors remain
• Fix SKU in "Small piece of string"
• Click Commit
• Result: 3 rows without errors + 2 empty rows
• Expected: 2 records with validation errors remain

Best regards
Blama

[Isomorphic]

Apologies for the incomplete fix, please try Jan 18 build and let us know how it worked for you.

[Blama]

Hi Isomorphic,

to me it looks like it is working as expected in the online showcase using v12.0p_2020-01-18.

Thank you & Best regards
Blama