Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

    12.1p Tahoe disabled skin issues - Buttons

    Hi Isomorphic,

    playing around with the online 12.1p Skin editor (ISC_121_BRANCH_2021-08-10_1628560231_jenkins_node1/SKINEDITOR Development Only), I found various issues with disabled controls. I'll put them in separate threads.

    Disabled buttons missing / looking active:
    Click image for larger version

Name:	Buttons.png
Views:	79
Size:	56.8 KB
ID:	266175

    Best regards
    Blama

    #2
    The missing disabled icons have been ported from 13.0.

    The "Show Disabled styling" button just calls setDisabled() on the top-level VLayout in the preview iframe, so it won't affect a menu or similar that's been opened manually and isn't a child of the VLayout/is above a click-mask.

    We've addressed this by just closing all menus when "Show Disabled Styling" is clicked - 12.1 and 13.0.

    Comment


      #3
      Hi Isomorphic,

      could you update the skin editor to a current version of 12.1p or 13.0p? It's still on ISC_121_BRANCH_2021-08-10_1628560231_jenkins_node1
      I also think it would make sense to have a separate 12.1p and a 13.0p version, depending on which version a user uses.

      Best regards
      Blama

      Comment


        #4
        Hi Isomorphic,

        this one is still open (regarding the online editor).
        It would be great to have daily updated versions of the 12.1p, 13.0p and 13.1d Skin editors in order to see the changes you incorporate to fix issues in this area.
        The online editor still is at ISC_121_BRANCH_2021-08-10_1628560231_jenkins_node1

        Best regards
        Blama

        Comment


          #5
          Hi Isomorphic,

          this is still an open issue. The deployed version is still ISC_121_BRANCH_2021-08-10_1628560231_jenkins_node1.
          I don't know if this is just the GUI to edit the skin or also the version of the templates.
          As now 13.0p is out for quite some time, I think that this should really be addressed.

          Also, the Reify editor under https://create.reify.com/themes/ is using an non-current (but newer) version: REIFY_DEPLOY_211007_2022-01-29_1643475804_jenkins_node3

          Looking at disabled styles in the Reify editor (presumably SC 13.0p_2022-01-29(?)) I can see that a lot of the issues reported here and in other threads were fixed. But reporting more only makes really sense if the skins served are current with possible fixes from reports made.

          Best regards
          Blama

          Comment


            #6
            Hi Isomorphic,

            12.1p (not 13.0p) has an color-gradient for disabled scrollbars. I don't think this is on purpose.
            Just add disabled:true to this sample (v12.1p_2022-08-24).

            Click image for larger version

Name:	Gradient.png
Views:	21
Size:	2.9 KB
ID:	268530

            Best regards
            Blama

            Comment


              #7
              Thanks for the report - it isn't clear why, but this gradient appeared only in Tahoe in 12.1 - it's been fixed for tomorrow's builds.

              Comment


                #8
                Hi Isomorphic,

                I can see this is fixed.

                Best regards
                Blama

                Comment

                Working...
                X