[Blama]

Hi Isomorphic,

I can see most of the points are addressed in SNAPSHOT_v13.1d_2024-06-11.
(6) and (9) are fine for me the way they are as well.

For the others I found these:
(3) There is still a search icon and no X to delete the text, but this is fine as well if it is on purpose
(5) Drag selection still possible, but on the opening caret only, not in the text anymore:


(10) I just realized you are already using the idea I had here to build the pickList-ResultSet.
Could you also by default add a sortBy and not just a groupBy to the request?
Also, it seems this request customizable, as it is already using a specialized operationId and the docs for deriveUniqueValues mention MultiPickerItem.optionFilterContext.

Apart from a "normal" example using SetFilterItem one using expandedPickListFields would be nice.

I also noticed you ported back SetFilterItem to 13.0p, which of course is great, but it is not in the docs there. Is this on purpose?

Best regards
Blama

[Isomorphic]

hi Blama,

We've addressed most of these for tomorrow's builds. Numbers 6 and 9 have not been modified for now.

For 10, the issue there is that there are lots of records in the test-data for that DS with "units" set to null. We see a blank entry appear at the top of the list, not in the second position, and it works as you expect when you set it (returning records where "units" is unset). Please let us know if you have more to say on this one.

[Blama]

Hi Isomorphic,

regarding my reports I can see that (1) and (2) are fixed, but (3) to (10) are still open (using SNAPSHOT_v13.1d_2024-06-05).
Claudio's issue from #13 is my (5).

Best regards
Blama

[claudiobosticco]

Thanks, I see it's fixed, now it only remains the little visual glitch of the selected entries vertical alignment

[Isomorphic]

Thanks Claudio - this regressed yesterday and was already fixed, in time for today's builds

[claudiobosticco]

SNAPSHOT_v13.1d_2024-06-04/AllModules Development Only

Hello, I've just noticed that with the latest build and the testcase from the post #1, now the filter editor height is lower than usual:

[claudiobosticco]

(5) Selected entries not centered:

hello Isomorphic I still see this issue noted by Blama.

[claudiobosticco]

Ah, thanks for the follow-up - we had a few CSS transitions in Shiva that were affecting "all", which includes visibility of course.

We've modified those transitions and you should find the issue fixed in today's builds, dated March 29 or later.

SmartClient Version: SNAPSHOT_v13.1d_2024-03-30/AllModules Development Only (built 2024-03-30)

I see it's fixed, thank you very much

[Isomorphic]

Ah, thanks for the follow-up - we had a few CSS transitions in Shiva that were affecting "all", which includes visibility of course.

We've modified those transitions and you should find the issue fixed in today's builds, dated March 29 or later.

We'll follow up on the other issues in this thread when we have them addressed.

[claudiobosticco]

(2) Scrollknobs not disappearing.gif:
As you can see the Scrollknobs from the SetFilterItem-scrollbar take a few ms to disappear after the SetFilterItem has disappeared

SmartClient Version: SNAPSHOT_v13.1d_2024-03-28/AllModules Development Only (built 2024-03-28)

Hi Isomorphic now I see this same effect, but for the new Shiva checkboxes

[Blama]

Hi Isomorphic,

(10) using the testcase below here (SNAPSHOT_v13.1d_2024-03-26), it seems that the valueList picked up from the .ds.xml for "Units" for the filterEditor is amended by an empty entry (in 2nd position, which is also strange). Is this really on purpose and necessary? This does not happen for the foreignKey field "Category".

Best regards
Blama

isc.ListGrid.create({
    ID: "supplyList",
    width:500, height:300, alternateRecordStyles:true,
    dataSource: supplyItem,
    fields:[
        {name:"SKU"},
        {name:"itemName"},
        {name:"description"},
        {name:"category", filterEditorType: "SetFilterItem"},
        {name:"units", filterEditorType: "SetFilterItem"}
    ],
    autoFetchData: true,
    showFilterEditor: true,
    filterOnKeypress: true,
    fetchDelay: 500
});

[Blama]

Hi Isomorphic,

no, the gif for (2) is animated, but it is also only sometimes playing for me. Here again, hopefully better.

(2) Scrollknobs not disappearing.gif:
As you can see the Scrollknobs from the SetFilterItem-scrollbar take a few ms to disappear after the SetFilterItem has disappeared

Best regards
Blama

[Isomorphic]

Thanks for feedback! We agree with most of these and will address them.

On #2, we don't quite understand what you mean. Perhaps you mean to post an animation - we see a still frame. Or if the still frame shows what you mean, can you circle the "scroll knobs"? We only see the track buttons from the scrollbar for the grid as a whole, which are expected to be there.

[Blama]

(8) I personally think that "comma space" is a better list separator than just "space" here:
(9) The popup is not opaque, which I don't think helps here. But might be on purpose:

[Blama]

(6) "all", "items", "except" are capital letter (might be on purpose and then OK):
(7) The "X" icon to remove an item is minimal too high, so that is is not round, but cut off at the top and bottom (Shiva Spacious and I think all densities):