Announcement

Collapse
No announcement yet.
X
  • Filter
  • Time
Clear All
new posts

  • Isomorphic
    replied
    Yes, we fixed this yesterday - it applied to any auto-sizing fields

    Leave a comment:


  • claudiobosticco
    replied
    SmartClient Version: SNAPSHOT_v13.1d_2024-07-25/AllModules Development Only (built 2024-07-25)

    Originally posted by Isomorphic View Post
    The other issue where there's no separator between the last two fields - no, that's not normal and we'll update again here when it's been fixed, along with the opacity issue from #24.
    I think this was the only issue still open in this thread, but now I see it's fixed, thank you very much.

    Leave a comment:


  • Isomorphic
    replied
    The issue from #24 was a bit mysterious - it presented as an opacity which we couldn't find being directly applied, but we do perform some tricky pushing backwards and forwards of styles for Buttons, between the content div and the outer table.

    We did correct opacities for disabled buttons, tabs, sections and so on, so most likely one of those fixes addressed this one. Always nice. :)

    Leave a comment:


  • claudiobosticco
    replied
    SmartClient Version: SNAPSHOT_v13.1d_2024-07-05/AllModules Development Only (built 2024-07-05)


    Originally posted by Isomorphic View Post
    A partial update - the issue with the sorterButton being clipped is addressed for today's builds - it's now the proper size, not clipped and the right color.
    I see it's fixed, thank you very much

    Originally posted by Isomorphic View Post
    [cut]...along with the opacity issue from #24.
    this seems also fixed, isn't it?

    Leave a comment:


  • Isomorphic
    replied
    A partial update - the issue with the sorterButton being clipped is addressed for today's builds - it's now the proper size, not clipped and the right color.

    The other issue where there's no separator between the last two fields - no, that's not normal and we'll update again here when it's been fixed, along with the opacity issue from #24.

    Leave a comment:


  • claudiobosticco
    replied
    SmartClient Version: SNAPSHOT_v13.1d_2024-07-03/AllModules Development Only (built 2024-07-03)

    Originally posted by Isomorphic View Post
    hi Claudio,

    On post #16, we've fixed icon-scaling in Buttons and Menus - both of these were widget-level issues, their iconWidth/Height attributes weren't included for scaling for any image-type.

    We've also made changes that cause sizes specified directly in an SVG string, like "size:12,12;", to also be scaled. You would specify sizes like that for better control independent of the container-size - but those icons would never scale, because scaling is applied to widget-attributes like iconWidth/Height, and setting "size:w,h" in a src string side-steps those scaled values.

    Auto-scaling specified "size" attributes in SVG strings seems like the best default behavior, since other SVGs will be scaled and SVG can scale without loss of quality. But, you can disable it by setting "scale:false;" in your src string if you want to - for example, we've set scale:false on the ends of scrollbars, which don't get wider with density, so the icons probably shouldn't scale up either.
    I see the icon-scaling issue in Buttons and Menus is fixed (and I also like the iconBaseStyle color), and I also see that the sizes specified in the SVG string are scaling.

    Leave a comment:


  • claudiobosticco
    replied
    SmartClient Version: SNAPSHOT_v13.1d_2024-07-03/AllModules Development Only (built 2024-07-03)

    Originally posted by Isomorphic View Post
    hi Claudio,

    For the initial report about right-aligned SectionHeader open/close icons, we agree that icons on the right feel out of place when there are other icons or inlined components there - so, we've switched the icons to the left in Obsidian and Twilight, and made them lighter and more visible in Twilight.
    much better!
    Originally posted by Isomorphic View Post
    The issue with disabled opacity from #24 is being looked into.
    I see it's fixed, thank you very much

    Last edited by claudiobosticco; 3 Jul 2024, 05:23.

    Leave a comment:


  • claudiobosticco
    replied
    Originally posted by Isomorphic View Post
    [cut]
    for example, we've set scale:false on the ends of scrollbars, which don't get wider with density, so the icons probably shouldn't scale up either.
    Hello, maybe related to this, there's a problem with the arrow for the sorterButton (this is from fetchOperationFS sample):

    Click image for larger version

Name:	2024-07-03 10.13.12.jpg
Views:	59
Size:	1.8 KB
ID:	272799
    this is with Spacious density, as you may see the arrow is clipped on its right.

    Also, is it normal that I don't see the separator between the "In Stock" and "Next Shipment" column?

    Leave a comment:


  • Isomorphic
    replied
    hi Claudio,

    For the initial report about right-aligned SectionHeader open/close icons, we agree that icons on the right feel out of place when there are other icons or inlined components there - so, we've switched the icons to the left in Obsidian and Twilight, and made them lighter and more visible in Twilight.

    The issue with disabled opacity from #24 is being looked into.

    Leave a comment:


  • Isomorphic
    replied
    On your question from #21, you can try out the changes mentioned there in the next build, dated June 29 or later. We also added a FormItem.iconBaseStyle attribute, which is now set to "icon" in Shiva - so arbitrary SVG icons, without a cssClass specified, will now get the color from the skin's "icon" class in FormItems, rather than inheriting the formItem's text-color, which is a bit darker than we want for icons in this skin.

    We'll take a look at the opacity difference among the buttons from #24 and get back to you.
    Last edited by Isomorphic; 28 Jun 2024, 22:22.

    Leave a comment:


  • claudiobosticco
    replied
    Hello, yes, I mean the background opacity.

    This is after clicking "Try it":
    Click image for larger version  Name:	2024-06-28 18.57.53.jpg Views:	0 Size:	5.8 KB ID:	272755
    Pressing Tab doesn't make a difference. Neither clicking the "Stretch Button".

    This is while hovering the "Stretch Button":
    Click image for larger version  Name:	2024-06-28 19.00.09.jpg Views:	0 Size:	5.4 KB ID:	272756

    Leave a comment:


  • Isomorphic
    replied
    Sorry, what is the difference you are seeing there? The background opacity?

    Did you try pressing Tab to change the selected button?
    Last edited by Isomorphic; 28 Jun 2024, 07:12.

    Leave a comment:


  • claudiobosticco
    replied

    Hello, another note about this test case, in Shiva I see a difference between the MenuButton and the IButton which I don't see in other skins:


    Click image for larger version

Name:	2024-06-28 15.14.05.jpg
Views:	76
Size:	6.9 KB
ID:	272739
    not sure what it's causing this in the CSS

    Leave a comment:


  • claudiobosticco
    replied
    Wow, these sounds as great enhancements, in which build will I find them?

    Leave a comment:


  • Isomorphic
    replied
    hi Claudio,

    On post #16, we've fixed icon-scaling in Buttons and Menus - both of these were widget-level issues, their iconWidth/Height attributes weren't included for scaling for any image-type.

    We've also made changes that cause sizes specified directly in an SVG string, like "size:12,12;", to also be scaled. You would specify sizes like that for better control independent of the container-size - but those icons would never scale, because scaling is applied to widget-attributes like iconWidth/Height, and setting "size:w,h" in a src string side-steps those scaled values.

    Auto-scaling specified "size" attributes in SVG strings seems like the best default behavior, since other SVGs will be scaled and SVG can scale without loss of quality. But, you can disable it by setting "scale:false;" in your src string if you want to - for example, we've set scale:false on the ends of scrollbars, which don't get wider with density, so the icons probably shouldn't scale up either.

    Leave a comment:

Working...
X